Messages in this thread | | | Date | Mon, 16 Jul 2007 21:12:26 -0400 | From | Jeff Garzik <> | Subject | Re: block/bsg.c |
| |
Andrew Morton wrote: > Yup, but the concern (from Al, iirc) was that someone could change the code > later on, add a new bug and have that bug hidden by the unneeded > initialisation.
True.
That's why #gccbug went the safe route, took the cost of extra instructions, and initialized it to zero.
> uninitialized_var() has the advantage that it generates no code, whereas "= > 0" often adds instructions. Plus of course it is self-documenting, greppable-for > and centrally alterable.
Agreed.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |