Messages in this thread | | | Date | Tue, 17 Jul 2007 01:28:20 +0900 | From | "Akinobu Mita" <> | Subject | Re: [PATCH 3/10] sysfs: fix error handling in create_files() |
| |
2007/7/17, Cornelia Huck <cornelia.huck@de.ibm.com>: > On Mon, 16 Jul 2007 22:52:30 +0900, > Akinobu Mita <akinobu.mita@gmail.com> wrote: > > > Current error handling in create_files() attempts to remove > > all attributes passed by argument by remove_files(). But it should > > only remove the attributes that have been successfully added. > > While this is certainly cleaner, a question out of curiousity: Does > this fix any problem you saw? sysfs_hash_and_remove() used to be safe > on non-existing attributes...
Maybe I folded all suspicious bugfixes that I found while I spend a lot of time to pass my cpu hotplug/unplug test script.
I'll test again without this patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |