lkml.org 
[lkml]   [2007]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
    On Mon, 16 Jul 2007, Jens Axboe wrote:
    > On Mon, Jul 16 2007, Geert Uytterhoeven wrote:
    > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote:
    > > > Ah, that explains it. flush_dcache_page() is used in some drivers.
    > > > I'll update my patches. Thanks for the comments!
    > >
    > > Does this look OK?
    > > - Replaced KM_USER0 by KM_IRQ0 (all routines are either called from an
    > > interrupt handler, from .request_fn (ps3disk), or from .queuecommand
    > > (ps3rom))
    >
    > That looks good.
    >
    > > - Add a call to flush_kernel_dcache_page() in routines that write to buffers
    >
    > Hmm, I would have thought a flush_dcache_page() would be more
    > appropriate, the backing could be page cache pages.

    OK, I'll change it to flush_dcache_page().

    With kind regards,

    Geert Uytterhoeven
    Software Architect

    Sony Network and Software Technology Center Europe
    The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

    Phone: +32 (0)2 700 8453
    Fax: +32 (0)2 700 8622
    E-mail: Geert.Uytterhoeven@sonycom.com
    Internet: http://www.sony-europe.com/

    Sony Network and Software Technology Center Europe
    A division of Sony Service Centre (Europe) N.V.
    Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium
    VAT BE 0413.825.160 · RPR Brussels
    Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
    \
     
     \ /
      Last update: 2007-07-16 15:03    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean