lkml.org 
[lkml]   [2007]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] drivers/mmc/core/: make 4 functions static
On Sun, Jul 15, 2007 at 06:52:34PM +0200, Pierre Ossman wrote:
> On Fri, 13 Jul 2007 01:56:02 +0200
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > This patch makes the following needlessly global functions static:
> > - sd_ops.c: mmc_wait_for_app_cmd()
> > - core.c: mmc_start_request()
>
> I am a bit torn about these two. Even though we don't cater to
> out-of-tree stuff, having these as exported symbols shows that they are
> part of the API. Removing them might risk people going about doing
> something silly because they don't know the functionality exists, and
> we might not spot it at patch review time.

If mmc_start_request() is considered part of an API people should use,
why isn't there a prototype in a header file?

> Rgds

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-16 04:37    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site