| | Date | Sat, 14 Jul 2007 11:49:14 +0100 | | From | Christoph Hellwig <> | | Subject | Re: [patch 1/8] Kprobes - do not use kprobes mutex in arch code |
| |
On Fri, Jul 13, 2007 at 09:21:34PM -0400, Mathieu Desnoyers wrote: > Remove the kprobes mutex from kprobes.h, since it does not belong there. Also > remove all use of this mutex in the architecture specific code, replacing it by > a proper mutex lock/unlock in the architecture agnostic code.
This is not very nice for avr32/sparc64 which have a noop arch_remove_kprobe and now need to take a mutex to do nothing. Maybe you can find a nice way to avoid that?
Except for this issue making kprobes_mutex static to kprobes.c sounds like a good improvement.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|