lkml.org 
[lkml]   [2007]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: sysfs: release mutex when kmalloc() failed in sysfs_open_file().
On Tue, 10 Jul 2007 13:56:46 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明  <yoshfuji@linux-ipv6.org> wrote:

> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
> index b502c71..1f64ce5 100644
> --- a/fs/sysfs/file.c
> +++ b/fs/sysfs/file.c
> @@ -283,6 +283,7 @@ static int sysfs_open_file(struct inode *inode, struct file *file)
> mutex_lock(&inode->i_mutex);
> if (!(set = inode->i_private)) {
> if (!(set = inode->i_private = kmalloc(sizeof(struct sysfs_buffer_collection), GFP_KERNEL))) {
> + mutex_unlock(&inode->i_mutex);
> error = -ENOMEM;
> goto Done;
> } else {

All this code is totally different in Greg's development tree, so this
fix really is only applicable to 2.6.22.x.

I suppose we could apply this to -stable, but given GFP_KERNEL's present behaviour
for small allocations it's pretty theoretical.

Unless you've enabled fault-injection in the page allocator, or if you get
oom-killed in that allocation. In which case your kernel is dead.

So hm, perhaps you'd best send this to stable@kernel.org.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-13 07:29    [W:0.080 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site