lkml.org 
[lkml]   [2007]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 012 of 20] knfsd: nfsd4: make readonly access depend on pseudoflavor
On Fri, Jul 13, 2007 at 12:27:04AM -0700, Andrew Morton wrote:
> On Tue, 10 Jul 2007 12:26:15 +1000 NeilBrown <neilb@suse.de> wrote:
>
> > +static inline int EX_RDONLY(struct svc_export *exp, struct svc_rqst *rqstp)
> > +{
> > + struct exp_flavor_info *f;
> > + struct exp_flavor_info *end = exp->ex_flavors + exp->ex_nflavors;
> > +
> > + for (f = exp->ex_flavors; f < end; f++) {
> > + if (f->pseudoflavor == rqstp->rq_flavor)
> > + return f->flags & NFSEXP_READONLY;
> > + }
> > + return exp->ex_flags & NFSEXP_READONLY;
> > +}
>
> It is fortunate that this inlined monster has only one callsite.
>
> otoh, given that it has only one callsite, perhaps it should be private
> to fs/nfsd/vfs.c.

Absolutely. Pluse a sane lower-case name and removing the inline qualifier
please.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-13 11:57    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site