Messages in this thread | | | Date | Thu, 12 Jul 2007 12:22:57 +0100 | From | Andy Whitcroft <> | Subject | Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode |
| |
The next version of checkpatch.pl (0.08) should have support for a number of the missed sylistics you mention. Will let them soak for a bit to ensure we're not majorly regressing anything else.
-apw
ERROR: braces {} are not necessary for single statements #4: FILE: Z11.c:1: +if (EXT4_I(inode)->i_extra_isize >= new_extra_isize) {
WARNING: declaring multiple variables together should be avoided #9: FILE: Z11.c:6: +unsigned int total_size, shift_bytes, temp = ~0U;
WARNING: multiple assignments should be avoided #12: FILE: Z11.c:9: +is->s.not_found = bs->s.not_found = -ENODATA;
WARNING: kfree(NULL) is safe this check is probabally not required #16: FILE: Z11.c:13: +if (bs) + kfree(bs);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |