Messages in this thread | | | Date | Thu, 12 Jul 2007 11:10:43 +0200 | From | Pavel Machek <> | Subject | Re: blink driver power saving |
| |
Hi!
> > > I'll take patches. Ofcourse we'll have to keep the current EV_LED interface > > > for compatibility. > > > > Here's a working version. For some reason, it only works with capslock > > led. (But so does your code, is that thinkpad problem?) > > My code does blink NumLock on my box (Dell) so I wonder why it does not > on your box...
setleds does not work here, either, so...
> Anyway, as far as the patch goes - I don't think we want to do it this > way for a couple of reasons: > > 1. It does not reflect the true device hierarchy - LEDs are not children > of input devices, they are children of whatever device that owns input > device. So in case of AT keyboard LEDs should grow from corresponding > serio port, not input device and so atkbd should register all of its > leds.
I'm not sure what you mean here. Should the code be moved to atkbd.c? ...and then duplicated to usbkbd.c?
> 2. LEDs will stop working if input device is grabbed via EVIOCSGRAB. > I think that grab should not cross subsystem boundaries.
Well, if userspace grabbed a LED, it would make sense to stop blinking it from heartbeat, no? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |