Messages in this thread | | | Date | Tue, 10 Jul 2007 21:42:21 -0700 | From | Andrew Morton <> | Subject | Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs |
| |
On Tue, 10 Jul 2007 23:21:49 -0400 "Cédric Augonnet" <cedric.augonnet@gmail.com> wrote:
> 2007/7/10, Andrew Morton <akpm@linux-foundation.org>: > > Hi all, > > > > + size = sizeof(struct transaction_stats_s); > > > + s->stats = kmalloc(size, GFP_KERNEL); > > > + if (s == NULL) { > > > + kfree(s); > > > + return -EIO; > > > > ENOMEM > > I'm sorry if i missed some point, but i just don't see the use of such > a kfree here, not sure Andrew meant you should only return ENOMEM > instead, but why issuing those kfree(NULL), instead of just a if (!s) > return ENOMEM ? >
You found a bug. It was meant to be
if (s->stats == NULL)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |