lkml.org 
[lkml]   [2007]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/7] fallocate() implementation in i386, x86_64 and powerpc
    On Wed, Jul 11, 2007 at 12:10:34PM +1000, Stephen Rothwell wrote:
    > On Wed, 11 Jul 2007 01:50:00 +0530 "Amit K. Arora" <aarora@linux.vnet.ibm.com> wrote:
    > >
    > > --- linux-2.6.22.orig/arch/x86_64/ia32/sys_ia32.c
    > > +++ linux-2.6.22/arch/x86_64/ia32/sys_ia32.c
    > > @@ -879,3 +879,11 @@ asmlinkage long sys32_fadvise64(int fd,
    > > return sys_fadvise64_64(fd, ((u64)offset_hi << 32) | offset_lo,
    > > len, advice);
    > > }
    > > +
    > > +asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_lo,
    > > + unsigned offset_hi, unsigned len_lo,
    > > + unsigned len_hi)
    >
    > Please call this compat_sys_fallocate in line with the powerpc version -
    > it gives us a hint that maybe we should think about how to consolidate
    > them. I know other stuff in that file is called sys32_ ... but it is time
    > for a change :-)

    I think this can be handled as a separate patch once this patchset
    is in mainline. Since, anyhow we will need to do this for other sys32_
    calls which are already there...

    --
    Regards,
    Amit Arora


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-11 10:15    [W:0.021 / U:0.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site