Messages in this thread | | | Date | Wed, 11 Jul 2007 21:40:07 +0200 | From | Luca <> | Subject | Re: [PATCH] Enable legacy support for serial ports when SERIAL_8250_PNP is disabled |
| |
On 7/9/07, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote: > On Monday 09 July 2007 11:30:59 am Luca wrote: > > On 7/9/07, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote: > > > If you turn off > > > PNP completely, you will have "pnp_platform_devices == 0", and the > > > existing code will do what you need. > > > > Well for me it's a non-issue, I'm able to "work-around" it in many > > ways. My point is that a configuration that used to work and is still > > valid suddenly doesn't work anymore. > > You're right about that, and it is a legitimate issue. But given the > fact that (PNP && !SERIAL_8250_PNP) should be relatively unusual, my > opinion is that it's not worth extra ifdefs in legacy_serial.c. > > If you have to use any workarounds like "legacy_serial.force", I think > that's a bug, and I'll fix it.
Ok, I double-checked: the serial port is usable during boot with PNP enabled, so no problem with dropping my patch.
Luca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |