lkml.org 
[lkml]   [2007]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][RFC] network splice receive v3
    On Wed, Jul 11, 2007 at 11:19:27AM +0200, Jens Axboe wrote:
    > Subject: [PATCH] splice: don't assume regular pages in splice_to_pipe()
    >
    > Allow caller to pass in a release function, there might be
    > other resources that need releasing as well. Needed for
    > network receive.
    >
    > diff --git a/fs/splice.c b/fs/splice.c
    > index 3160951..4b4b501 100644
    > --- a/fs/splice.c
    > +++ b/fs/splice.c
    > @@ -254,11 +254,16 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe,
    > }
    >
    > while (page_nr < spd_pages)
    > - page_cache_release(spd->pages[page_nr++]);
    > + spd->spd_release(spd, page_nr++);

    Rather than requiring the caller set this, shouldn't we just
    allow it? Especially given there is only one non-page user?

    while (page_nr < spd_pages)
    - page_cache_release(spd->pages[page_nr++]);
    + if (spd->spd_release)
    + spd->spd_release(spd, page_nr++);
    + else
    + page_cache_release(spd->pages[page_nr++]);

    Joel

    --

    "Any man who is under 30, and is not a liberal, has not heart;
    and any man who is over 30, and is not a conservative, has no brains."
    - Sir Winston Churchill

    Joel Becker
    Principal Software Developer
    Oracle
    E-mail: joel.becker@oracle.com
    Phone: (650) 506-8127
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-11 20:21    [W:0.076 / U:0.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site