lkml.org 
[lkml]   [2007]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version
On Wed, 11 Jul 2007 15:05:27 +1000 Neil Brown <neilb@suse.de> wrote:

>
> It just occurred to me:
>
> If i_version is 64bit, then knfsd would need to be careful when
> reading it on a 32bit host. What are the locking rules?
>
> Presumably it is only updated under i_mutex protection, but having to
> get i_mutex to read it would seem a little heavy handed.
>
> Should it use a seqlock like i_size?
> Could we use the same seqlock that i_size uses, or would we need a
> separate one?
>

seqlocks are a bit of a pain to use (we've had plenty of deadlocks on the
i_size one). We could reuse inode.i_lock for this modification. Its
mandate is "general purpose innermost lock to protect stuff in this inode".


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-11 07:25    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site