| Date | Tue, 10 Jul 2007 20:35:32 +0200 (CEST) | From | Jan Engelhardt <> | Subject | Re: [x86 setup 20/33] Console-writing code for the new x86 setup code |
| |
On Jul 9 2007 19:51, H. Peter Anvin wrote: >+ >+static inline int isdigit(int ch) >+{ >+ return (ch >= '0') && (ch <= '9'); >+}
I'd say static inline unsigned int isdigit(unsigned char), since ASCII does not realistically exceed 255.
>+static int strnlen(const char *s, int maxlen)
unsigned int, and unsigned int, too? The glibc strnlen type also uses unsigned types.
Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|