lkml.org 
[lkml]   [2007]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateTue, 10 Jul 2007 11:23:15 +0100
From"Duane Griffin" <>
SubjectRe: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets
On 10/07/07, Satyam Sharma <ssatyam@cse.iitk.ac.in> wrote:
> + /* Avoid taking lock and disabling interrupts unnecessarily */
> + if (unlikely(list_empty(&target_list)))
> + return;

Is the unlikely a good idea here? Not having any targets may be
unusual but it isn't ridiculous. It might even be a sensible default
for distros. My (very limited) understanding of unlikely is that it
could impose a very large penalty in that case and would make a very
marginal difference at best in the common case.

Cheers,
Duane.

--
"I never could learn to drink that blood and call it wine" - Bob Dylan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-10 12:25    [from the cache]
©2003-2010