lkml.org 
[lkml]   [2007]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Videopix Frame Grabber: Fix unreleased lock in vfc_debug()
    Videopix Frame Grabber: vfc_debug() doesn't release the device lock
    when copy_from_user() fails

    Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>

    ---

    diff --git a/drivers/sbus/char/vfc_dev.c b/drivers/sbus/char/vfc_dev.c
    index 6afc7e5..1cbdabd 100644
    --- a/drivers/sbus/char/vfc_dev.c
    +++ b/drivers/sbus/char/vfc_dev.c
    @@ -248,6 +248,7 @@ static int vfc_debug(struct vfc_dev *dev, int cmd, void __user *argp)
    buffer,inout.len);

    if (copy_to_user(argp,&inout,sizeof(inout))) {
    + vfc_unlock_device(dev);
    kfree(buffer);
    return -EFAULT;
    }
    --
    Matthias Kaehlcke
    Linux Application Developer
    Barcelona


    Usually when people are sad, they don't do anything. They just cry over
    their condition. But when they get angry, they bring about a change
    (Malcolm X)
    .''`.
    using free software / Debian GNU/Linux | http://debian.org : :' :
    `. `'`
    gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-07-01 17:17    [W:0.019 / U:4.876 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site