Messages in this thread | | | Date | Fri, 8 Jun 2007 14:48:49 -0400 (EDT) | From | "Robert P. J. Day" <> | Subject | Re: blank filenames in /sys/modules, kernel 2.6.21 |
| |
On Fri, 8 Jun 2007, Pete Zaitcev wrote:
> On Fri, 8 Jun 2007 11:32:32 -0700, Greg KH <greg@kroah.com> wrote: > > > > and from drivers/usb/core/usb.c: > > > > > > /* format to disable USB on kernel command line is: nousb */ > > > __module_param_call("", nousb, param_set_bool, param_get_bool, &nousb, 0444); > > > Pete added that back in December of 2005 (git-blame rocks...). So what > > has changed recently to cause this to do different things in sysfs? > > > > Robert, what do you suggest we change this usage to look like? > > Aww. I thought it was a nice patch, but my foresight was inadequate. > > The problem I tried to fix was related to strncmp used in the code which > supported __setup(). Our installer, Anaconda, recognizes both "nousb" and > "nousbstorage" - in theory. In practice, passing "nousbstorage" switched > USB completely off because of improper strncmp(). If we back out my patch, > this problem is going to reoccur. > > We might want to ask Jeremy Katz if "nousbstorage" is even used anymore, > then revert all this if not. Or, we can add a name somehow and live > with it visible in sysfs...
there appears to be no reference to "nousbstorage" anywhere in the tree. go for it.
rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |