lkml.org 
[lkml]   [2007]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] Watchdog driver for AT32AP700X devices
From
Date
On Thu, 2007-06-07 at 16:09 -0700, Andrew Morton wrote:
> On Wed, 6 Jun 2007 16:04:07 +0200
> Hans-Christian Egtvedt <hcegtvedt@atmel.com> wrote:
>
> > This patch adds support for the built in watchdog in AT32AP700X devices.
> >
> > Tested on AT32AP7000 and ATSTK1000.
> >
> > Hardware documentation can be found in the AT32AP7000 datasheet.
> >
> > ...
> >
> > +static int __init at32_wdt_probe(struct platform_device *pdev)
> > +{

<cut start of _probe>

> > + wdt->regs = ioremap(regs->start, regs->end - regs->start + 1);
>
> I see an ioremap(), but there are no iounmap()s anywhere.

Hmm, that would be my fault, please see the attach patch, it should
apply clean to -mm after your two -fix{1,2} patches.

--
With kind regards,

Hans-Christian Egtvedt, siv.ing. (M.Sc.)
Applications Engineer - AVR32 System Solutions - Atmel Norway
[unhandled content-type:application/mbox]
\
 
 \ /
  Last update: 2007-06-08 09:47    [W:0.077 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site