Messages in this thread | | | Date | Fri, 8 Jun 2007 01:21:52 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH] update checkpatch.pl to version 0.03 |
| |
On Thu, Jun 07, 2007 at 11:22:48PM +0100, Alan Cox wrote: > On Thu, 7 Jun 2007 21:34:13 +0200 > Adrian Bunk <bunk@stusta.de> wrote: > > > On Thu, Jun 07, 2007 at 04:28:20PM +0200, Jan Engelhardt wrote: > > > > > > On Jun 6 2007 11:05, Jesper Juhl wrote: > > > > > > > > - Source files should be 7bit ASCII > > > > > > Nah. Think of.... > > > > > > MODULE_AUTHOR("J. Ørsted <jorsted@foobar.com>"); > > >... > > > > NO! > > > > Code must be 7bit ASCII. > > This includes everything that gets into the kernel image. > > Disagree Adrian > > For quoted strings you want to include Unicode where appropriate, and the > names of people happens to be highly appropriate. Trashing non US names > is just rude, and in many cases extremely problematic because losing > accent marks totally changes the meaning of the word and the > pronunciation of the name. > > Now anyone who puts UTF-8 in the driver name or module options should get > a lot of NAKs but putting it in the Author name is precisely where it is > appropriate and correct. I suspect Author names are almost the only case > where this is appropriate and/or neccessary.
I added a MODULE_AUTHOR("J. Ørsted <jorsted@foobar.com>") into the "raw" module:
# echo $LANG C # modinfo --version module-init-tools version 3.3-pre11 # modinfo raw filename: /lib/modules/2.6.21.2/kernel/drivers/char/raw.ko author: J. Ã ^ the cursor hangs here
So for implementing your proposal, we have to: - get module-init-tools fixed and - document that 2.6.23 (or whichever will be the first kernel to support UTF-8 in MODULE_AUTHOR) will require updated module-init-tools.
Oh, and when you are anyway planning to break older userspace, can you remove the obsolete "raw" driver at the same time? ;-)
> Alan
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |