Messages in this thread | | | Date | Thu, 7 Jun 2007 14:41:52 -0700 (PDT) | From | Davide Libenzi <> | Subject | Re: [patch 7/8] fdmap v2 - implement sys_socket2 |
| |
On Thu, 7 Jun 2007, Linus Torvalds wrote:
> On Thu, 7 Jun 2007, Eric Dumazet wrote: > > > > This is a nice idea, but 32/64 compat code is going to hate it :) > > It should be fairly simple for 32/64-bit compat code too. > > The compat code should just call the compat system call > > > syscall_indirect() would be writen in assembly for each arch, since there is > > no generic syscall table. Thats really a lot of work, especially if we want to > > mess with signal mask, umask ... > > No no no. That would be horribly idiotic. > > The thing should be 99% generic code, ie we would have > > syscall_indirect(..) > { > long retval; > > .. set up signals/flags .. > retval = arch_syscall_indirect(syscall, args); > .. unsetup signals/flags .. > return retval; > } > > compat_syscall_indirect(..) > { > int retval; > > .. set up signals/flags .. > retval = compat_arch_syscall_indirect(syscall, args); > .. unsetup signals/flags .. > return retval; > } > > and the *only* thing that each architecture would need to do is that > (trivial) arch_syscall_indirect() thing (and the compat version, if > applicable). And those literally should be generally pretty damn trivial.
Ok, I like this better honestly. I really did not want to win the Oscar for the 2007 Syscall Spammer of the year :)
- Davide
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |