lkml.org 
[lkml]   [2007]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] [Patch 1/4] statistics: no include hell for users
Dave Hansen wrote:
> On Wed, 2007-06-06 at 23:33 +0200, Martin Peschke wrote:
>> struct statistic_interface {
>> /* private: */
>> struct list_head list;
>> - struct dentry *debugfs_dir;
>> - struct dentry *data_file;
>> - struct dentry *def_file;
>> + void *debugfs_dir;
>> + void *data_file;
>> + void *def_file;
>
> If you don't actually dereference the pointer, you should just be able
> to declare:
>
> struct dentry;
>
> and be done with it, right? You don't _need_ the includes to have just
> pointers.

Ah, looks like an established trick in kernel include files.
I guess I can revert the other, seq_file related change then as well.
Thank you. Will change my local copy.

Martin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-07 02:35    [W:0.070 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site