![]() | |||||||||||||
Messages in this thread |
Andrew Morton wrote: > Yeah, this caused test.kernel.org to fail as well. > > There are a couple of fixes in > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm1/hot-fixes/ > which should get things going again. > > Robert, I spent some time picking at > mmconfig-validate-against-acpi-motherboard-resources.patch then got bored > with fiddling with it and reverted it outright. The minimal fix would be to put #ifdef CONFIG_PCI_MMCONFIG around the call to pci_mmcfg_late_init in drivers/acpi/bus.c. > > Please, we need to get those prototypes of pci_mmcfg_early_init() and > pci_mmcfg_late_init() into some sane place which works on all > architectures, not duplicate one of them in a C file and even see if we can > avoid the #ifdef CONFIG_PCI_MMCONFIG in arch/i386/pci/init.c > > This code area is really messy, due partly to the x86_64 and i386 sharing. > Any changes in there need careful testing and checking. I'm not sure there's a point in making the prototypes for those functions global to all architectures, since it's unlikely anything non-X86 could make use of them with any similar semantics. We could provide a no-op definition of those functions to avoid the need to ifdef the calls, though. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-06-07 02:03 [from the cache] ©2003-2008 | |||||||||||||