lkml.org 
[lkml]   [2007]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] [Patch 4/4] lock contention tracking slimmed down

* Martin Peschke <mp3@de.ibm.com> wrote:

> - lock_time_inc() vs. statistic_add_util()

please fix the coding style in lib/statistic.c. It's full of:

{
unsigned long long i;
if (value <= stat->u.histogram.range_min)
return 0;
put a newline after variable sections.

and:

on_each_cpu(_statistic_barrier, NULL, 0, 1);
return 0;

preferably use a newline before 'return' statements as well. (this is
not always necessary, but in the above case it looks better)

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-07 01:13    [W:0.328 / U:0.164 seconds]
©2003-2014 Jasper Spaans. Advertise on this site