Messages in this thread Patch in this message |  | | | Date | Wed, 6 Jun 2007 23:32:38 +0200 (CEST) | | From | Geert Uytterhoeven <> | | Subject | i2c module aliases |
| |
From browsing through file2alias.c, I have the impression there's a missing TO_NATIVE() conversion in the handling of 16-bit (hence, endian-affected) i2c IDs. This will cause the module aliases to be incorrect when cross-compiling for a system with a different endianness. Is that correct? If yes, the patch below adds the missing conversion.
Of course, no driver seems to use `MODULE_DEVICE_TABLE(i2c, ...)' yet, hence nobody noticed.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
--- a/scripts/mod/file2alias.c +++ b/scripts/mod/file2alias.c @@ -390,6 +390,7 @@ static int do_vio_entry(const char *file static int do_i2c_entry(const char *filename, struct i2c_device_id *i2c, char *alias) { + i2c->id = TO_NATIVE(i2c->id); strcpy(alias, "i2c:"); ADD(alias, "id", 1, i2c->id); return 1; Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |