lkml.org 
[lkml]   [2007]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [-mm patch] kernel/sched{,_fair}.c: make code static
    On Wed, Jun 06, 2007 at 09:30:23AM +0200, Ingo Molnar wrote:
    >
    > * Andrew Morton <akpm@linux-foundation.org> wrote:
    >
    > > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
    > > >
    > > > ---
    > > >
    > > > BTW: Please don't #include C files in sched.c
    > >
    > > Yeah.
    >
    > In this case it's not that bad. It makes the source quite a bit cleaner
    > and avoids having to create artificial interfaces, global functions,
    > etc. between the .o's.
    >...

    The idiom used in the kernel for such code is "global code and compile
    the files separately". The expected inclusion for a C file into the
    kernel is through the Makefile, and everything else is surprising when
    looking through the code.

    "artificial interfaces" is not a problem since these are completely
    private interfaces you can change at any time.

    > Ingo

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-06 14:35    [W:0.020 / U:62.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site