| Date | Wed, 06 Jun 2007 12:29:13 +0100 | From | Paulo Marques <> | Subject | Re: [Patch 05/18] fs/logfs/logfs.h |
| |
Jörn Engel wrote: > --- /dev/null 2007-03-13 19:15:28.862769062 +0100 > +++ linux-2.6.21logfs/fs/logfs/logfs.h 2007-06-03 19:34:07.000000000 +0200 > @@ -0,0 +1,398 @@ > +/* > + * fs/logfs/logfs.h > + * > + * As should be obvious for Linux kernel code, license is GPLv2 > + * > + * Copyright (c) 2005-2007 Joern Engel > + * > + * Private header for logfs. > + */ > +#ifndef fs_logfs_logfs_h > +#define fs_logfs_logfs_h > + > +#define __CHECK_ENDIAN__ > + > + > +#include <linux/crc32.h> > +#include <linux/fs.h> > +#include <linux/kallsyms.h>
Including kallsyms.h is not really needed in this header file, is it?
I don't have time / knowledge to review the rest of the code, but I always keep an eye out for kallsyms usage...
-- Paulo Marques - www.grupopie.com
"Very funny Scotty. Now beam up my clothes." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|