lkml.org 
[lkml]   [2007]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC: 2.6 patch] drivers/video/pm3fb.c: possible cleanups
From
Date
On Tue, 2007-06-05 at 00:12 +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:

> -
> -int __init pm3fb_init(void)
> -{
> - /*
> - * For kernel boot options (in 'video=pm3fb:<options>' format)
> - */
> -#ifndef MODULE
> - char *option = NULL;
> -
> - if (fb_get_options("pm3fb", &option))
> - return -ENODEV;

The cleanup is good, but we should still leave the above with
the second parameter as NULL so the driver can also listen to
global options, such as video=pm3fb:off.

I'll fix this up. Thanks.

Krzysztof,

I think this patch is okay. If you need to add an option parser
for your driver, you can always add this in the future.

Tony


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-05 12:49    [from the cache]
©2003-2011 Jasper Spaans