lkml.org 
[lkml]   [2007]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] neaten lguest boot code (again)
On Wed, 06 Jun 2007 12:37:39 +1000 Rusty Russell <rusty@rustcorp.com.au> wrote:

> (This cleanup seems to have gotten lost in rc3-mm1? It was in rc2-mm1
> called lguest-the-host-code-update-for-mm-simplify-boot_params.patch)
>
> Andrew patched up lguest after the boot parameters became a proper
> structure, but in fact it can be considerably neatened.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> drivers/lguest/lguest.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> ===================================================================
> --- a/drivers/lguest/lguest.c
> +++ b/drivers/lguest/lguest.c
> @@ -444,8 +444,7 @@ __init void lguest_init(void *boot)
> {
> /* Copy boot parameters first. */
> memcpy(&boot_params, boot, PARAM_SIZE);
> - memcpy(boot_command_line,
> - __va(*(unsigned long *)((void *)&boot_params + NEW_CL_POINTER)),
> + memcpy(boot_command_line, __va(boot_params.hdr.cmd_line_ptr),
> COMMAND_LINE_SIZE);
>
> paravirt_ops.name = "lguest";

I dropped it because it depended upon mm-simplify-boot_params.patch which
for some reason disappeared but now appears to have reappeared.

Shall resurrect.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-06 04:51    [W:0.213 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site