Messages in this thread | | | Date | Mon, 4 Jun 2007 11:12:45 +0200 | From | Jörn Engel <> | Subject | Re: [Patch 04/18] include/linux/logfs.h |
| |
On Sun, 3 June 2007 23:42:25 +0200, Arnd Bergmann wrote: > On Sunday 03 June 2007, Jörn Engel wrote: > > +struct logfs_je_spillout { > > + __be64 so_segment[0]; > > +}__packed; > > All the on-disk data structures you define in this file have naturally > aligned members, so the __packed attribute is not needed.
Amen. It is purely paranoia and I don't even know who is out to get me.
> However, I think it causes gcc to generate larger and slower code > on some architectures, because now it has to assume that the data > structure itself has no more than byte alignment. > > I'd simply remove all instances of __packed therefore. In order > to verify that you got it right in all cases, build with > '-Wpadded -Wpacked'.
Fine with me. Will do.
Jörn
-- Ninety percent of everything is crap. -- Sturgeon's Law - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |