lkml.org 
[lkml]   [2007]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: SLUB: Return ZERO_SIZE_PTR for kmalloc(0)
Hi Christoph,

On 6/4/07, Christoph Lameter <clameter@sgi.com> wrote:
> /*
> - * We should return 0 if size == 0 (which would result in the
> - * kmalloc caller to get NULL) but we use the smallest object
> - * here for legacy reasons. Just issue a warning so that
> - * we can discover locations where we do 0 sized allocations.
> + * The behavior for zero sized allocs changes. We no longer
> + * allocate memory but return ZERO_SIZE_PTR.
> + * WARN so that people can review and fix their code.
> */
> WARN_ON_ONCE(size == 0);

I thought the whole point of this patch was to get rid of the WARN_ON
as you will get a nice oops if you dereference the pointer?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-04 21:15    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site