lkml.org 
[lkml]   [2007]   [Jun]   [4]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
DateMon, 4 Jun 2007 12:58:57 +0800
FromWANG Cong <>
SubjectRe: [RFC] Documentation/CodingStyle: Add rules for goto labels
On Sun, Jun 03, 2007 at 11:35:43AM -0400, Jeff Garzik wrote:
>Randy Dunlap wrote:
>>On Sun, 3 Jun 2007 15:29:39 +0100 Al Viro wrote:
>>
>>>On Sun, Jun 03, 2007 at 10:24:50PM +0800, WANG Cong wrote:
>>> 
>>>>+Do care when you use Lindent to indent your code, since it may use 
>>>>spaces
>>>>+instead of tabs before a goto label and it may also align the label in a
>>>>+wrong position. A goto label should be aligned in the column that is 8
>>>>+characters ahead of the statement just below this label. Please fix it 
>>>>manually
>>>>+if you find Lindent is wrong.
>>>Lindent is wrong, but the style you are advocating is, at the very
>>>least, not universal.  Equally (if not more) common is putting label
>>>in column 1, period.  Regardless of indentation level of the statement
>>>following it.
>>
>>ack Al's style.
>
>Seconded.  All my code contains the goto label in the first column.
>
>IMO any other goto label indentation is silly, because it obscures the 
>goto label within the code block.
>
>	Jeff

Thanks for all comments!

I just wonder, if a goto label is nested in a while/for/if/switch block, aligning it in
the first column maybe a bit ugly. (I know mostly it is not in any while/for/if/switch block.)

Regards!


WANG Cong

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-04 05:01    [W:2.488 / U:0.030 seconds]
©2003-2008 Jasper Spaans