lkml.org 
[lkml]   [2007]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: libata & no PCI: dma_[un]map_single undefined
> > CONFIG_PCI=n
> > CONFIG_ATA=m
> >
> > This seems to be a valid configuration since libata can drive non-PCI
> > devices too?

Yep.

> It really makes no sense to allow this on Sparc, there are no
> non-PCI Sparc ATA controllers.

There are PCMCIA controllers and PCI/PCMCIA/Cardbus adapters for the
Sparc platform I thought ?

> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index b4a8d60..7d893a6 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -8,6 +8,7 @@ menuconfig ATA
> depends on BLOCK
> depends on !(M32R || M68K) || BROKEN
> depends on !SUN4 || BROKEN
> + depends on !(SPARC64 && !PCI)


NAK - this is the wrong approach. PCI=n ATA=m should compile. Sparc is
not the only problem case. The DMA handling bits of libata are fairly
nicely split out but they are stuck in the same file and unconditionally
compiled in.

I'll have a poke at this when I get a bit of time if Jeff doesn't.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-04 15:33    [W:2.220 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site