Messages in this thread | | | Date | Fri, 29 Jun 2007 01:31:18 -0400 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH] cross-architecture ELF clean up |
| |
Paul Mackerras wrote: >> =================================================================== >> --- a/arch/powerpc/platforms/cell/io-workarounds.c >> +++ b/arch/powerpc/platforms/cell/io-workarounds.c >> @@ -9,6 +9,7 @@ >> #undef DEBUG >> >> #include <linux/kernel.h> >> +#include <linux/sched.h> >> > > Why is this needed? You've added #include <linux/sched.h> to 7 files > without explanation - and I can't see that you have removed a > corresponding #include from any header, have you? >
asm-powerpc/elf.h included sched.h, and it in turn was being included by something else. With the cleanups in this patch, asm-powerpc/elf.h is no longer being included, so io-workarounds.c needs kernel/sched.h for a declaration of init_mm.
Similarly with the others; they all failed to compile without linux/sched.h.
J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |