Messages in this thread Patch in this message | | | Date | Thu, 28 Jun 2007 12:45:05 +0400 | From | Alexey Dobriyan <> | Subject | [PATCH] x86_64: arch_pick_mmap_layout() fixlet |
| |
sparse now warns about arch/x86_64/mm/mmap.c:15:3: warning: returning void-valued expression
Generated code looks correct: there is jump to the end of arch_pick_mmap_layout() after ia32_pick_mmap_layout(), but this should be fixed regardless.
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru> ---
arch/x86_64/mm/mmap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
--- a/arch/x86_64/mm/mmap.c +++ b/arch/x86_64/mm/mmap.c @@ -11,8 +11,10 @@ void arch_pick_mmap_layout(struct mm_struct *mm) { #ifdef CONFIG_IA32_EMULATION - if (current_thread_info()->flags & _TIF_IA32) - return ia32_pick_mmap_layout(mm); + if (current_thread_info()->flags & _TIF_IA32) { + ia32_pick_mmap_layout(mm); + return; + } #endif mm->mmap_base = TASK_UNMAPPED_BASE; if (current->flags & PF_RANDOMIZE) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |