Messages in this thread | | | Date | Thu, 28 Jun 2007 00:46:24 +0200 | From | Rodolfo Giometti <> | Subject | Re: [PATCH] LinuxPPS (with new syscalls API) |
| |
On Wed, Jun 27, 2007 at 06:49:48PM +0100, David Woodhouse wrote: > > Looks better. All I can find to complain about is the fact that you > return whatever copy_from_user() returns. Don't -- that's the number of > bytes left to copy. It should be if (copy_from_user(..)) return -EFAULT;
Ok, I'll fix it.
Just last question: I still don't well understand where I should declare the new compat_sys_time_pps_fetch() syscall... it's automagically defined by the system when CONFIG_COMPAT is enabled? :-o
Thanks for your help,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@gnudd.com Embedded Systems giometti@linux.it UNIX programming phone: +39 349 2432127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |