Messages in this thread | | | Date | Wed, 27 Jun 2007 13:37:17 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] balance parenthesis in serial core |
| |
On Wed, 27 Jun 2007 22:22:00 +0200 Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
> Hello, > > This patch balances the parenthesis imbalance in serial core. > > Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl> > > drivers/serial/serial_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-2.6.22-rc6-bo-a/drivers/serial/serial_core.c 2007-06-27 22:05:41.000000000 +0200 > +++ linux-2.6.22-rc6-bo-b/drivers/serial/serial_core.c 2007-06-27 22:08:56.000000000 +0200 > @@ -1158,9 +1158,9 @@ static void uart_set_termios(struct tty_ > * appropriately by set_termios() in tty_ioctl.c > */ > #ifdef CIBAUD > -#define RELEVANT_CFLAG(cflag) ((cflag) & ~(CIBAUD|CBAUD) > +#define RELEVANT_CFLAG(cflag) ((cflag) & ~(CIBAUD|CBAUD)) > #else > -#define RELEVANT_CFLAG(cflag) ((cflag) & ~(CIBAUD|CBAUD) > +#define RELEVANT_CFLAG(cflag) ((cflag) & ~(CIBAUD|CBAUD)) > #endif > #define RELEVANT_IFLAG(iflag) ((iflag) & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK)) > if ((cflag ^ old_termios->c_cflag) == 0 &&
Thanks. so... why shouldn't we just remove the buggy&&unused RELEVANT_CFLAG defines?? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |