lkml.org 
[lkml]   [2007]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [uml-devel] [PATCH 4/5] UML - Simplify helper stack handling
    On Tue, Jun 26, 2007 at 01:35:50PM -0700, Andrew Morton wrote:
    > > sprintf(title, data->title, data->device);
    > > - pid = run_helper(NULL, NULL, argv, NULL);
    > > + pid = run_helper(NULL, NULL, argv);
    > > if (pid < 0) {
    > > err = pid;
    > > printk(UM_KERN_ERR "xterm_open : run_helper failed, "
    >
    > Something's gone wrong here. My copy of this file has
    >
    > pid = run_helper(NULL, NULL, argv, &stack);

    Looks like you're applying patches out of order. This is from the
    14th, while a patch from the 13th ("UML - xterm driver tidying") has
    - pid = run_helper(NULL, NULL, argv, &stack);
    ...
    + pid = run_helper(NULL, NULL, argv, NULL);

    If you don't want to fiddle with this, just drop it and I'll rediff
    against the next -mm and resend.

    Jeff

    --
    Work email - jdike at linux dot intel dot com
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-26 23:57    [W:0.022 / U:30.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site