lkml.org 
[lkml]   [2007]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] sis5513: backport short cables support from pata_sis.c
Bartlomiej Zolnierkiewicz wrote:

> Backport short cables support from pata_sis.c.

> This patch should allow UDMA > 2 modes on ASUS A6K.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> Index: b/drivers/ide/pci/sis5513.c
> ===================================================================
> --- a/drivers/ide/pci/sis5513.c
> +++ b/drivers/ide/pci/sis5513.c
[...]
> @@ -796,10 +796,33 @@ static unsigned int __devinit init_chips
> return 0;
> }
>
> +struct sis_laptop {
> + u16 device;
> + u16 subvendor;
> + u16 subdevice;
> +};
> +
> +static const struct sis_laptop sis_laptop[] = {
> + /* devid, subvendor, subdev */
> + { 0x5513, 0x1043, 0x1107 }, /* ASUS A6K */
> + /* end marker */
> + { 0, }
> +};
> +
> static u8 __devinit ata66_sis5513(ide_hwif_t *hwif)
> {
> + struct pci_dev *pdev = hwif->pci_dev;
> + const struct sis_laptop *lap = &sis_laptop[0];
> u8 ata66 = 0;
>
> + while (lap->device) {
> + if (lap->device == pdev->device &&
> + lap->subvendor == pdev->subsystem_vendor &&
> + lap->subdevice == pdev->subsystem_device)
> + return ATA_CBL_PATA40_SHORT;
> + lap++;
> + }
> +

The code even starts looking generic enough to be put into helper...

> if (chipset_family >= ATA_133) {
> u16 regw = 0;
> u16 reg_addr = hwif->channel ? 0x52: 0x50;

MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-26 20:53    [W:0.044 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site