lkml.org 
[lkml]   [2007]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: NAK (bashizm in the /bin/sh script): [PATCH v3] doc/oops-tracing: add Code: decode info
    On Tue, 26 Jun 2007 12:50:27 +0200 Arne Georg Gleditsch wrote:

    > Randy Dunlap <randy.dunlap@oracle.com> writes:
    > > OTOH, you also didn't supply a patch. If you do this, I'll be
    > > glad to consider it. If I can read it, that is.
    >
    > I like bash as much as the next guy, but (to my surprise) /bin/sh on
    > my current workstation is actually dash. How about just replacing the
    > substring-interpolations with:
    >
    > if [ $marker -ne 0 ]; then
    > beforemark=`echo "$code" | cut -c-$((marker - 1))`
    > [..]
    > # and fix code at-and-after marker
    > code=`echo "$code" | cut -c$marker-`
    > fi
    >
    > and be done with it?


    Are these 2 line changes all that is needed?

    I sort of expected expressions like $((a + 2)) to need change also...
    maybe not for dash, but for sh?

    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-26 19:23    [W:0.023 / U:0.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site