Messages in this thread | | | Date | Tue, 26 Jun 2007 09:33:56 -0700 | From | "Keshavamurthy, Anil S" <> | Subject | Re: [Intel IOMMU 05/10] Intel IOMMU driver |
| |
On Mon, Jun 25, 2007 at 11:25:11PM -0700, Andrew Morton wrote: > On Tue, 19 Jun 2007 14:37:06 -0700 "Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com> wrote: > > > None of these actually _need_ to be macros and it would be better to > implement them in C. That way things are more self-documenting, more > pleasant to read, more likely to get commented and you'll fix the > two bugs wherein the argument to a macro is evaluated more than once. Agree. Will send a patch when I get back from OLS as any changes to this needs thorugh testing.
-Anil - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |