Messages in this thread | | | Subject | Re: [RFC PATCH 0/6] Convert all tasklets to workqueues | From | Steven Rostedt <> | Date | Mon, 25 Jun 2007 17:03:29 -0400 |
| |
On Mon, 2007-06-25 at 22:50 +0200, Tilman Schmidt wrote:
> Ok, I'm reassured. I'll look into converting these to a work queue > then, although I can't promise when I'll get around to it. > > In fact, if these timing requirements are so easy to meet, perhaps > it doesn't even need its own work queue, and just making each > tasklet into a work item and queueing them to the global queue > with schedule_work() would do? Or am I getting too reckless now?
I'm sure you probably wouldn't have a problem with using just schedule_work. But that's shared and you don't know with what. A function in the keventd work queue can call schedule (not recommended, but with closed source drivers, you'd never know. schedule_work is EXPORT_SYMBOL not EXPORT_SYMBOL_GPL).
So, if you convert it to work queues, I'd strongly recommend adding a new instance.
-- Steve
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |