lkml.org 
[lkml]   [2007]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm] PM: Prevent frozen user mode helpers from failing the freezing of tasks
    On 06/25, Rafael J. Wysocki wrote:
    >
    > On Monday, 25 June 2007 12:43, Oleg Nesterov wrote:
    >
    > > Second, call_usermodehelper's path should first increment the counter, and only
    > > then check usermodehelper_disabled,
    >
    > It does this already.

    Ah, sorry, I looked at this patch without seeing the underlying code.

    BTW, isn't it better to rename new_helper/helper_finished to
    helper_lock/helper_unlock ?

    > If I understand that correctly, it should suffice to place smp_mb() after
    > usermodehelper_disabled = 1; in usermodehelper_pm_callback() and another
    > smp_mb() after atomic_inc(&running_helpers); in new_helper().
    >
    > Is that correct?

    Afaics, yes.

    Oleg.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-25 17:33    [W:0.022 / U:0.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site