lkml.org 
[lkml]   [2007]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch 1/3] add the fsblock layer
    From
    Date
    Nick Piggin <npiggin@suse.de> writes:


    [haven't read everything, just commenting on something that caught my eye]

    > +struct fsblock {
    > + atomic_t count;
    > + union {
    > + struct {
    > + unsigned long flags; /* XXX: flags could be int for better packing */

    int is not supported by many architectures, but works on x86 at least.

    Hmm, could define a macro DECLARE_ATOMIC_BITMAP(maxbit) that expands to the smallest
    possible type for each architecture. And a couple of ugly casts for set_bit et.al.
    but those could be also hidden in macros. Should be relatively easy to do.

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-24 16:35    [W:3.689 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site