Messages in this thread | | | Date | Sat, 23 Jun 2007 15:33:44 -0700 (PDT) | From | Trent Piepho <> | Subject | Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c |
| |
On Sat, 23 Jun 2007, Satyam Sharma wrote: > On 6/23/07, Trent Piepho <xyzzy@speakeasy.org> wrote: > > [...] > > What you have is tristate depends on bool depends on tristate. The bool > > between the two tristates "promotes" the first tristate from m to y. > > [...] > > Or another way, add the dependencies of the menuconfig to the if statement: > > diff -r dfbe7cc4e21e drivers/media/video/Kconfig > > --- a/drivers/media/video/Kconfig Thu Jun 21 16:02:50 2007 -0700 > > +++ b/drivers/media/video/Kconfig Fri Jun 22 13:10:43 2007 -0700 > > @@ -691,7 +691,7 @@ menuconfig V4L_USB_DRIVERS > > depends on USB > > default y > > > > -if V4L_USB_DRIVERS > > +if V4L_USB_DRIVERS && USB > > > > source "drivers/media/video/pvrusb2/Kconfig" > > > > Now all the usb drivers will gain USB as a dependency directly and can't be > > set to something higher than USB. > > Ok, so we add this as solution 2.(c) to the reply I just sent to Jan :-) > > But I still prefer 2.(b) -- making the config scripts intelligent so that if a > given "menuconfig FOO depends on BAR", then all the "config BAZ"s > inside this menuconfig also automatically "depend on" BAR too.
Of course, there currently is no "inside" a menuconfig. You would have to do something like make everything inside an "if FOO / endif" gain not just a dependency on FOO, but also gain a dependency on all of FOO's dependencies.
> This is simpler in the long run because it requires least amount > (actually none) of redundant typing and would continue to work in > the future if/when the: > > menuconfig FOO > if FOO > ... > endif # FOO > > idiom is converted to an: > > configmenu FOO > ... > endconfigmenu # FOO > > kind of idiom ...
Like that I suggested here? http://article.gmane.org/gmane.linux.kernel/524823
Basically, make menuconfig work like menu does, except the menu itself can be turned on and off. Instead of having menuconfig work like a config, but with some kind of "menu" hint. It seems like the former is more in line with what menuconfig is actually used for. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |