Messages in this thread | | | Date | Sun, 24 Jun 2007 00:05:07 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [PATCH 2/4] fbdev: add connector entries for uvesafb |
| |
On Sat, Jun 23, 2007 at 11:06:27AM -0700, Andrew Morton (akpm@linux-foundation.org) wrote: > On Sat, 23 Jun 2007 12:51:46 +0200 Michal Januszewski <spock@gentoo.org> wrote: > > > Add connector's idx and val constants for v86d and uvesafb. > > > > Also change the maximum message size to 4k to allow transfers of VBE > > data blocks from userspace. > > > > Signed-off-by: Michal Januszewski <spock@gentoo.org> > > --- > > include/linux/connector.h | 7 ++++--- > > 1 files changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/connector.h b/include/linux/connector.h > > index 10eb56b..46b2aba 100644 > > --- a/include/linux/connector.h > > +++ b/include/linux/connector.h > > @@ -36,14 +36,15 @@ > > #define CN_VAL_CIFS 0x1 > > #define CN_W1_IDX 0x3 /* w1 communication */ > > #define CN_W1_VAL 0x1 > > +#define CN_IDX_V86D 0x4 > > +#define CN_VAL_V86D_UVESAFB 0x1 > > > > - > > -#define CN_NETLINK_USERS 4 > > +#define CN_NETLINK_USERS 5 > > > > /* > > * Maximum connector's message size. > > */ > > -#define CONNECTOR_MAX_MSG_SIZE 1024 > > +#define CONNECTOR_MAX_MSG_SIZE 4096 > > > > /* > > * idx and val are unique identifiers which > > > > > > Evgeniy, could you please review this? > > The need to add these enumerations for unrelated subsystems to connector.h > may get a bit ugly as time passes, but I guess it's OK for now.
Hi.
I have no problem with the patch, although it could be possible to split patch to two - add id and increase the size, but it is too minor nit.
Ack.
-- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |