lkml.org 
[lkml]   [2007]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH 4/6] Make DRM use the tasklet is-sched API
    From
    Date
    On Thu, 2007-06-21 at 23:36 -0700, Daniel Walker wrote:
    > On Fri, 2007-06-22 at 00:00 -0400, Steven Rostedt wrote:
    > > plain text document attachment (tasklet-driver-hacks.patch)
    > > Update the DRM driver to use the new tasklet API, which does not rely
    > > on the tasklet implementation details.
    > >
    > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    > >
    > >
    > > Index: linux-2.6.21-rt9/drivers/char/drm/drm_irq.c
    > > ===================================================================
    > > --- linux-2.6.21-rt9.orig/drivers/char/drm/drm_irq.c
    > > +++ linux-2.6.21-rt9/drivers/char/drm/drm_irq.c
    > > @@ -461,7 +461,7 @@ void drm_locked_tasklet(drm_device_t *de
    > > static DECLARE_TASKLET(drm_tasklet, drm_locked_tasklet_func, 0);
    > >
    > > if (!drm_core_check_feature(dev, DRIVER_HAVE_IRQ) ||
    > > - test_bit(TASKLET_STATE_SCHED, &drm_tasklet.state))
    > > + tasklet_is_scheduled(&drm_tasklet))
    > > return;
    > >
    > > spin_lock_irqsave(&dev->tasklet_lock, irqflags);
    > >
    >
    >
    > No sense in having a patch just for this, may as well merge this with
    > patch 3 ..

    Wrong. patch 3 adds the API and this one makes use of it. Stevens split
    makes perfectly sense.

    tglx


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-22 08:53    [W:0.020 / U:179.388 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site