lkml.org 
[lkml]   [2007]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Oops in a driver while using SLUB as a SLAB allocator
On Fri, 22 Jun 2007, Linus Torvalds wrote:

> > Looks like it would indeed address the immediate issue on ARM -
> > IF they've no particular reason to be using kmalloc there.
>
> I think the right thing to do is do both of these things. I already
> applied Hugh's patch - it seemed like a total nobrainer to do at this
> stage in the 2.6.22 -rc series. But that doesn't mean that we should not
> _also_ look at "flush_dcache_page()" users.

Hugh's patch not address the complete issue. It only works right now
because the size of the allocation is page size and fits right into a slab
page. If debugging is enabled then the slab size will increase and the
"pages" will be misaligned which will lead to other sorts of funky
behavior. kmalloc allocations are only guaranteed to be aligned to
ARCH_KMALLOC_MINALIGN which is 4 to 8 bytes. If one must have a
page aligned entity out of a slab allocator then a custom slab needs to be
created.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-22 19:29    [W:0.214 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site