Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] Optional Beeping During Resume From Suspend To Ram. | Date | Thu, 21 Jun 2007 23:20:23 +0200 |
| |
Hi,
On Thursday, 21 June 2007 00:24, Nigel Cunningham wrote: > On Thursday 21 June 2007 08:09:26 Rafael J. Wysocki wrote: > > On Tuesday, 19 June 2007 23:33, Rafael J. Wysocki wrote: > > > On Tuesday, 19 June 2007 13:18, Nigel Cunningham wrote: > > > > Hi all > > > > > > > > Here's what I have after today's work. > > > > > > > > I haven't yet been able to test on x86, but can confirm that it works okay on > > > > x86_64. I'm currently working towards testing it on my old Omnibook. My P4 > > > > desktop won't resume from suspend to ram at all, and hasn't produced any > > > > beeps. > > > > > > > > I needed to move the BEEP invocation to after the data segment is reloaded, > > > > so that the test could access the variable. That was pretty tricky to find - > > > > no oops or anything bad prior, it just didn't beep when expected. > > > > > > > > A couple of notes: > > > > > > > > - I'd like to put the BEEP macro somewhere that can be shared by x86 32 and > > > > 64. If that's a good idea, any suggestions on where? Nothing occurs to me > > > > straight off. > > > > > > I don't know either. I think Andi is the right person to ask (CC added). > > > > > > > - I've just switched from Evo to Kmail. Please let me know if there's any > > > > mangling of the patch. > > > > Unfortunately, the message is encoded as "quoted printable" which results in > > the whitespace being mangled. > > > > > The patch looks good to me. I'll try to run it on an i386 tomorrow. > > > > I've recoded it and rediffed against -rc5 with the hibernation and suspend > > patchset. The resut is at > > > > http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc5/patches/29-Optional-Beeping-During-Resume-From-RAM.patch > > > > Well, my i386 test box doesn't seem to be able to beep at all. I'll have to > > look for another one ... > > Ok. No success with the Omnibook yet, though I did see it mentioned in Documentation/... as needing a vbepost. > > Think I found the right option. Does this patch come through better?
No, it's still "quoted printable", at least on my system (but I use Kmail too).
Greetings, Rafael
-- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |