Messages in this thread | | | Date | Thu, 21 Jun 2007 21:32:34 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] bracing the loop in kernel/softirq.c |
| |
[Jesper Juhl - Thu, Jun 21, 2007 at 07:20:33PM +0200] | From: Jesper Juhl <jesper.juhl@gmail.com> | To: Cyrill Gorcunov <gorcunov@gmail.com> | Cc: LKML <linux-kernel@vger.kernel.org> | Subject: Re: [PATCH] bracing the loop in kernel/softirq.c | Date: Thu, 21 Jun 2007 19:20:33 +0200 | > On 21/06/07, Cyrill Gorcunov <gorcunov@gmail.com> wrote: >> [Jesper Juhl - Wed, Jun 20, 2007 at 11:01:44PM +0200] >> | From: Jesper Juhl <jesper.juhl@gmail.com> >> | To: Cyrill Gorcunov <gorcunov@gmail.com> >> | Cc: LKML <linux-kernel@vger.kernel.org> >> | Subject: Re: [PATCH] bracing the loop in kernel/softirq.c >> | Date: Wed, 20 Jun 2007 23:01:44 +0200 >> | >> > On 20/06/07, Cyrill Gorcunov <gorcunov@gmail.com> wrote: >> >> This trivial patch adds braces over a one-line >> >> loop. That makes code...well... little bit >> >> convenient for (possible) further modifications. >> >> >> > That's generally not done. >> > >> > It's even in Documentation/CodingStyle : >> > >> > " >> > Do not unnecessarily use braces where a single statement will do. >> > >> > if (condition) >> > action(); >> > " >> >> look, the CodingStyle is absolutely right BUT: >> >> - dropping the braces are good solution for 'if' statement indeed >> - dropping the braces are _not_ good for 'do' - 'while' loop 'case >> it fails on further loop modifications. Moreover adding these >> braces >> we don't change amount of lines in code! So why souldn't we? I >> don't >> see any reason not to do. >> > > Personally, in this case, I don't care. I'm simply telling you that > usually that's not a patch that would get accepted, that's all. But > it's all up to the maintainer of that area of the kernel (whom you > probably want to at least Cc in addition to just LKML). :-) > > -- > Jesper Juhl <jesper.juhl@gmail.com> > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please http://www.expita.com/nomime.html >
Anyway, thanks for comments ;)
Cyrill
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |